D29201: KCMUtils: Add option to append service file to list of arguments

Méven Car noreply at phabricator.kde.org
Wed May 13 08:34:36 BST 2020


meven added inline comments.

INLINE COMMENTS

> kpluginselector.cpp:855
> +            }
> +            KCModuleProxy *currentModuleProxy = new KCModuleProxy(moduleInfo, moduleProxyParentWidget, arguments);
>              if (currentModuleProxy->realModule()) {

Adding a fileName field to KCModuleProxy would make more sense to me, and do it by default.
Plus KCModuleProxy has already access to the fileName since it receives moduleInfo. 
But I am not a specialist.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D29201

To: alex, #plasma, ngraham, meven, broulik, mart
Cc: mart, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200513/b02a0d16/attachment-0001.htm>


More information about the Kde-frameworks-devel mailing list