D29390: Respect QIcon::fallbackSearchpaths()

Nicolas Fella noreply at phabricator.kde.org
Mon May 11 19:13:40 BST 2020


nicolasfella added inline comments.

INLINE COMMENTS

> aacid wrote in kiconloader.cpp:1142
> I just realized that function is private, not really easy to use :/
> 
> anyhow do you think we should remove svgz?
> 
> Also i think using
> 
> const QStringList extensions = { QStringLiteral(".png"), QStringLiteral(".svg"), QStringLiteral(".svgz"), QStringLiteral(".xpm") };
> 
> should be a bit faster

I copied that list from somewhere else in KIconLoader. It would seem weird to me to support a different set of formats in the fallback than in the regular path

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D29390

To: nicolasfella, #plasma, #frameworks
Cc: kossebau, aacid, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200511/6c243ec2/attachment.htm>


More information about the Kde-frameworks-devel mailing list