D29485: [CopyJob] Check free space for remote urls before copying and other improvements

Ahmad Samir noreply at phabricator.kde.org
Sat May 9 09:15:48 BST 2020


ahmadsamir added inline comments.

INLINE COMMENTS

> dfaure wrote in copyjob.cpp:477
> This comment is now completely out of context. It used to be about NFS/SMB, now this information has gone and one is left wondering why kind of connections we're talking about (connection to the kioslave???)

I meant connection to the remote ulr/host; however e.g Dolphin already reports those connection errors in the status bar when it can't connect, so the comment is redundant now... (I tried to keep the original code/comments in tact, apparently that backfired spectacularly).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29485

To: ahmadsamir, #frameworks, dfaure, meven, sitter
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200509/7d1e966d/attachment-0001.htm>


More information about the Kde-frameworks-devel mailing list