D29397: KPreviewJob : Support for DeviceRatioPixel

Méven Car noreply at phabricator.kde.org
Fri May 8 12:35:41 BST 2020


meven added a comment.


  In D29397#666132 <https://phabricator.kde.org/D29397#666132>, @kossebau wrote:
  
  > For another stupid question (the first one was already asked by someone else and answered :) ):
  >  Given some generated thumbnails are cached, does the thumbnail cache specification support logical resolution?
  
  
  I am evolving here the specification : the images stored are stored with their HiDpi size (width * dpr, height * dpr), and then some metadata is written.
  When reading the cached version for large, the user expects a 256*256 (modulo aspect ratio) and can find a (256 * dpr, 256 * dpr) image (or can read the devicePixelRatio from metadata)
  You can see in https://phabricator.kde.org/D29526#C575294OL738 and line 582 how to detect and handle such a case.
  
  > How would cached thumbnails work cross-screen?
  
  Cache thumbnails with low dpr will look blurry on hidpi screen, other than that's not an issue.
  We would need applications to update to use Hidpi thumbnails to renew thumbnails.
  I might want to evict low dpr thumbnails.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29397

To: meven, dfaure, broulik, #frameworks
Cc: kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200508/f39fc462/attachment.htm>


More information about the Kde-frameworks-devel mailing list