D29123: Do not mark entry as uninstalled if uninstallation script failed

[Dan Leinir Turthra Jensen]

leinir accepted this revision.
leinir added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> installation.h:113
>       *
>       * The entry instance will be updated with any new information:
>       * <ul>

Not blocking, but the documentation probably wants fixing before you push - just swap this line for "The entry emitted by signalEntryChanged (only happens when the uninstallation is completed with non-critical errors) will be updated with any new information, in particular the following:"

REPOSITORY
  R304 KNewStuff

BRANCH
  arcpatch-D29123_1

REVISION DETAIL
  https://phabricator.kde.org/D29123

To: alex, #knewstuff, meven, ngraham, leinir
Cc: leinir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200507/81812ee5/attachment.htm>