D29461: Fix kio-extras build on Windows

Piyush Aggarwal noreply at phabricator.kde.org
Wed May 6 10:34:10 BST 2020


brute4s99 added inline comments.

INLINE COMMENTS

> sitter wrote in CMakeLists.txt:26
> Hm, I am a bit hazy on the details but I think this changes makes no sense. libssh (upstream) introduced an imported target `ssh`. For backwards compatibility we also inject this target when building with older libssh's than the latest (to be honest though, with libssh you basically always want the latest or you'll have an incredibly subpar experience).

I just built libssh 0.9.4, and kio-extras builds fine without this line change. Maybe we should try getting latest libssh onboard. Can I help in that somehow @vonreth ?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29461

To: brute4s99, vonreth, meven
Cc: sitter, meven, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200506/537061df/attachment.html>


More information about the Kde-frameworks-devel mailing list