D29420: Generate DBus interface

Nicolas Fella noreply at phabricator.kde.org
Tue May 5 23:25:18 BST 2020


nicolasfella added inline comments.

INLINE COMMENTS

> broulik wrote in notifybypopup.cpp:115
> Previously it would accept the signal from any service which I find odd, though. Could you maybe check git logs to see if there was a reason for this?
> It should survive restarts anyway and the service name is defined, so I really don't see why it used to be a blind connect.

git history until the frameworks split isn't really telling, I didn't bother looking further back

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D29420

To: nicolasfella, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200505/e353c51b/attachment.html>


More information about the Kde-frameworks-devel mailing list