D29445: [KOpenWithDialog] When pointing at a non-executable file print more meaningful error

David Faure noreply at phabricator.kde.org
Tue May 5 15:14:49 BST 2020


dfaure added inline comments.

INLINE COMMENTS

> apol wrote in kopenwithdialog.cpp:1006
> This patch D29170 <https://phabricator.kde.org/D29170> suggests that findExecutable won't find non-executables.
> 
> Something's wrong.

Right, hence the isEmpty() here. This check passes if 1) it doesn't exist, or 2) it's not executable.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29445

To: broulik, #frameworks, #vdg
Cc: dfaure, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200505/3a1aecbc/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list