D29391: Introduce setWindow and CloseWhenWindowActivated

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> knotification.h:582
>  
> +    /** Sets the window associated with this notification.
> +     *  This is relevant when using the CloseWhenWindowActivated flag.

And some remarks from a local API docs pedant :)

Please place the text not on the first line after "/**", but the second line only (for consistency at least). Also keep indent at one space in the following lines then again afte the asterisk.

Also wants a "@since" note, same with the getter :) Them being jealous on the one you gave to the flag.

I would also propose to place these methods for the new property before the two methods tagged with "@internal", to keep some ordering in the list of methods for the human reader of the code.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D29391

To: nicolasfella, #frameworks, broulik
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200503/7a491f5f/attachment.html>