D29335: Implement notification grouping on Android

[Nicolas Fella]

nicolasfella accepted this revision.
nicolasfella added a comment.
This revision is now accepted and ready to land.


  Haven't tested it, but the code looks sensible

INLINE COMMENTS

> NotifyByAndroid.java:171
> +        Notification.Builder builder;
> +        if (Build.VERSION.SDK_INT >= 26) {
> +            builder = new Notification.Builder(m_ctx, notification.channelId);

Please use https://developer.android.com/reference/android/os/Build.VERSION_CODES instead of hardcoding numbers

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29335

To: vkrause, nicolasfella
Cc: nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200501/94c4372a/attachment-0001.html>