D29336: Remove galago from method/variable naming
Nicolas Fella
noreply at phabricator.kde.org
Fri May 1 15:27:36 BST 2020
nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.
REVISION SUMMARY
With D29021 <https://phabricator.kde.org/D29021> the fallback notification system is gone and with it the need for differentating naming. Remove galago from the naming since it's outdated and might confuse readers unfamiliar with the code and its history. Also inline a now not needed function.
TEST PLAN
Still get notifications, action invoked signal is correctly sent
Depends on D29021 <https://phabricator.kde.org/D29021>
REPOSITORY
R289 KNotifications
BRANCH
nogalago
REVISION DETAIL
https://phabricator.kde.org/D29336
AFFECTED FILES
src/imageconverter.h
src/notifybypopup.cpp
src/notifybypopup.h
src/notifybyportal.cpp
To: nicolasfella, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200501/8bc92506/attachment.html>
More information about the Kde-frameworks-devel
mailing list