D28460: Add KCModuleStateProbe as base class for plugin

Kai Uwe Broulik noreply at phabricator.kde.org
Tue Mar 31 11:35:15 BST 2020


broulik added inline comments.

INLINE COMMENTS

> kcmodulestateprobe.h:21
> +
> +#ifndef KCMODULEDEFAULT_H
> +#define KCMODULEDEFAULT_H

`KCMODULESTATEPROBE_H`

> kcmodulestateprobe.h:25
> +#include <QObject>
> +#include <QVariantList>
> +#include <kcmutils_export.h>

Forward-declare

> kcmodulestateprobe.h:39
> +    virtual bool isDefaults() const = 0;
> +};
> +

Please add a `virtual_hook` so we can extend this class in the future without breaking ABI should we have the need to extract more data out of a settings module:

  virtual void virtual_hook(int id, void *data)

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D28460

To: bport, #plasma, ervin
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200331/729431d0/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list