D28298: Reduce superfluous changedEntriesChanged emissions

[Dan Leinir Turthra Jensen]

leinir added inline comments.

INLINE COMMENTS

> Button.qml:90
> -        value: ghnsDialog.engine.changedEntries
> -    }
>  

Given the various annoying side effects of the cleaner solutions, perhaps reintroduce this, but add a "when" clause to ensure it only happens when we want it to? Maybe something as simple as just checking it is only forwarded when engine is, in fact, not null might work... or, perhaps, if engine is not null, and also initialised? since it really shouldn't be giving you any changed entries until after initialisation has been completed... Meaning something like

  when: ghnsDialog.engine !== null && ghndDialog.engine.isInitialized

maybe perhaps could be...

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28298

To: broulik, #frameworks, leinir, ahiemstra
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200330/ef2451bc/attachment.html>