D28295: Introduce KNotificationJobUiDelegate

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Sat Mar 28 09:44:49 GMT 2020


kossebau added inline comments.

INLINE COMMENTS

> knotificationjobuidelegate.h:58
> +    class Private;
> +    Private *const d;
> +};

Using QScopedPointer or std::unique_ptr instead of raw pointer also avoids need to manually delete in destructor, also better practice these days.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D28295

To: broulik, #frameworks, nicolasfella, dfaure
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200328/8b857f1b/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list