D27338: Provide an initial implementation for input-method-unstable-v1

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> inputmethod_interface.cpp:153-154
> +{
> +    for (auto r : d->resourceMap())
> +        d->send_commit_state(r->handle, serial);
> +}

I don't understand why we need `resourceMap()` here. zwp_input_method_context_v1 is not a global so I would expect to see something like

  void InputMethodContextInterface::sendCommitState(uint32 serial)
  {
      d->send_commit_state();
  }

> inputmethod_interface.cpp:206-210
> +    void zwp_input_panel_surface_v1_destroy_resource(Resource * resource) override {
> +        wl_resource_destroy(resource->handle);
> +        if (resourceMap().isEmpty())
> +            q->deleteLater();
> +    }

Only delete `q`.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27338

To: apol, #kwin, #frameworks
Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200326/92ade070/attachment.html>