D28278: Move responsiblity for creating KService to CommandLauncherJob

[Kai Uwe Broulik]

broulik added a comment.


  Lovely simplification

INLINE COMMENTS

> kprocessrunner.cpp:119
>  {
> -    if (service && !service->entryPath().isEmpty()
> +    if (!service->entryPath().isEmpty()
>              && !KDesktopFile::isAuthorizedDesktopFile(service->entryPath())) {

I //think// we can still end up with a `null` `service` through `ApplicationLauncherJob`?

> kprocessrunner.cpp:145
>              data.setDescription(i18n("Launching %1", data.name()));
> -            if (!iconName.isEmpty()) {
> -                data.setIcon(iconName);
> -            } else if (service && !service->icon().isEmpty()) {
> +            if (service->icon().isEmpty()) {
>                  data.setIcon(service->icon());

`!isEmpty`

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28278

To: davidedmundson
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200325/baf0b2c1/attachment.html>