D28266: KPropertiesDialog: port KRun::run to ApplicationLauncherJob

David Faure noreply at phabricator.kde.org
Wed Mar 25 00:15:41 GMT 2020


dfaure created this revision.
dfaure added a reviewer: davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  KRun::run(exec, urls) is somewhere in between the two jobs.
  Since we know the name of the desktop file, we might as well use ApplicationLauncherJob here.
  Otherwise we would probably need a bit of KShell escaping to turn a QUrl into a command-line arg.

TEST PLAN
  With filelight installed, the button in the properties dialog works.
  With the .desktop file still installed but the executable renamed, an error message pops up as expected.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28266

AFFECTED FILES
  src/gui/applicationlauncherjob.h
  src/widgets/kpropertiesdialog.cpp

To: dfaure, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200325/833475dc/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list