D28260: [QML] Set the remaining time in the monitor more reliably

Stefan BrĂ¼ns noreply at phabricator.kde.org
Tue Mar 24 21:28:23 GMT 2020


bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The remaining time was only updated when the count of indexed files
  modulo 100 is 0. I.e. if already 1295 files are indexed, and 90 of these
  files are changed the indexed count goes down to 1205 and the update
  is never triggered.
  
  Use a QElapsedTimer to update the time when the file count changes, but
  at most once per second.

TEST PLAN
  Before:
  Check the "Total files indexed" from `balooctl status`
  Touch some large files (so the indexed count does not cross xx00)
  The "remaining time" in kinfocenter is not updated
  
  After:
  The remaining time is updated after ~1 second.

REPOSITORY
  R293 Baloo

BRANCH
  config_rework

REVISION DETAIL
  https://phabricator.kde.org/D28260

AFFECTED FILES
  src/qml/experimental/monitor.cpp
  src/qml/experimental/monitor.h

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200324/6e3e777a/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list