D28220: Switch to using Kirigami's ShadowedRectangle

Dan Leinir Turthra Jensen noreply at phabricator.kde.org
Mon Mar 23 14:52:46 GMT 2020


leinir created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
leinir requested review of this revision.

REVISION SUMMARY
  This switches from using the QML DropShadow to using the
  new, high efficiency ShadowedRectangle in Kirigami.
  
  - Modify (and equalise logic) in GridTileDelegate
  - Clean up EntryScreenshots, and use ShadowedRectangle
  - Also use ShadowedRectangle in the bigpreview and tile delegates

TEST PLAN
  No visible changes (as expected) from the switch
  Minor visible change from the EntryScreenshots modifications (now correctly shows the shadows all the way around)

REPOSITORY
  R304 KNewStuff

BRANCH
  switch-to-kirigami-shadowedrectangle (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28220

AFFECTED FILES
  src/qtquick/qml/private/EntryScreenshots.qml
  src/qtquick/qml/private/GridTileDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml

To: leinir
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200323/09e7158f/attachment.html>


More information about the Kde-frameworks-devel mailing list