D28122: Copy KFontDialog from KDELibs4Support to KWidgetAddons, now KFontChooserDialog

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> kfontchooserdialog.cpp:97
> +{
> +    KFontChooserDialog dlg(flags | KFontChooser::ShowDifferences, parent);
> +    dlg.setObjectName(QStringLiteral("Font Selector"));

Is having dialog objects on the stack a good idea?

What if the application gets closed while the dialog is open, would that not crash?

At least at some point people thought it was not a good idea, see https://blogs.kde.org/node/3919

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D28122

To: ahmadsamir, #frameworks, davidedmundson, cfeck, broulik, ervin, meven, bport, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200323/36f08122/attachment.html>