D28191: [KFontChooser] General code cleanup

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, cfeck, apol, bport.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  - Use new connect syntax
  - Prefix increment where appropriate
  - Replace foreach/iterator-based for with range-for
  - Remove (really) old TODOs

TEST PLAN
  make && ctest
  KFontChooser in e.g. Kate still loads and works as before

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  l-kfontchooser (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28191

AFFECTED FILES
  src/kfontchooser.cpp
  src/kfontchooser.h

To: ahmadsamir, #frameworks, cfeck, apol, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200321/68bd9938/attachment.html>