D28186: GIT_SILENT kpasswdserver, break long lines for readability; add braces around if

[Ahmad Samir]

ahmadsamir added a comment.


  In D28186#631962 <https://phabricator.kde.org/D28186#631962>, @dfaure wrote:
  
  > Nice.
  >
  > clang-format can't be configured to add missing braces,
  
  
  Nope, I'd have had to use clang-format (which requires a "compilation server", I read some docs, searched online, tried, then read more docs; found that it took me about half an hour and I still couldn't get it to work (it replaced all of two occurrences and then barfed), I realised it would have taken me 10 minutes to do it by hand, and get on with what's left of my life, which is what I did).
  
  > and to have a max line length?
  
  I used a .clang-format copied from clang-format.cmake from extra-cmake-modules, which has "ColumnLimit: 240", but that apparently leads to really long lines... why I didn't tweak the number? I forgot :D

REPOSITORY
  R241 KIO

BRANCH
  l-kpasswdserver-long-lines (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28186

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200321/72e23251/attachment.html>