D27883: Register spawned applications as an independent cgroups

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kprocessrunner.cpp:292
> +
> +    QDBusMessage message = QDBusMessage::createMethodCall(QStringLiteral("org.freedesktop.systemd1"),
> +                                   QStringLiteral("/org/freedesktop/systemd1"),

The code in this method should be in some #ifdef UNIX and not MAC, right?
Pretty pointless to make this DBus call on Windows ;)

> kprocessrunner.cpp:301
> +
> +    QList<uint> pidList = {static_cast<quint32>(m_process->pid())};
> +

(this is what made me think about Windows, where pid is a 64bit value).

> kprocessrunner.cpp:308
> +    message.setArguments({name, mode, QVariant::fromValue(properties), QVariant::fromValue(aux)});
> +    QDBusPendingCall reply = QDBusConnection::sessionBus().asyncCall(message);
> +}

And then? if we don't care about the async reply, maybe you should remove the left part of the equal sign?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27883

To: davidedmundson, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200321/0e78e1ad/attachment.html>