D28122: Move/port KFontDialog from KDELibs4Support to KWidgetAddons

Ahmad Samir noreply at phabricator.kde.org
Wed Mar 18 12:02:02 GMT 2020


ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, davidedmundson, cfeck, broulik, ervin, meven, bport.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  - Drop relative size bits, seems not that used
  - Use a KFontDialogPrivate class instead of KFontDialog::Private (see: https://mail.kde.org/pipermail/kde-frameworks-devel/2015-August/025956.html)
  - Port to QDialog
  
  See https://phabricator.kde.org/D27808 for more details about the reasons
  to make this port.

TEST PLAN
  it builds and kfontdialog works (see test app)

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  l-kfontdlg (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28122

AFFECTED FILES
  docs/pics/kfontdialog.png
  src/CMakeLists.txt
  src/kfontchooser.h
  src/kfontdialog.cpp
  src/kfontdialog.h
  tests/CMakeLists.txt
  tests/kfontdialogtest.cpp

To: ahmadsamir, #frameworks, davidedmundson, cfeck, broulik, ervin, meven, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200318/ed59ba7c/attachment.html>


More information about the Kde-frameworks-devel mailing list