D26858: Provide an implementation for the tablet interface

David Edmundson noreply at phabricator.kde.org
Tue Mar 17 14:33:03 GMT 2020


davidedmundson added inline comments.

INLINE COMMENTS

> tablet_interface.cpp:346
> +
> +TabletToolInterface *TabletSeatInterface::toolByHardwareId(quint64 serialId) const
> +{

We're mixing up hardwareId and hardwareSerial

this method is called toolByHardwareId calls an internal method called hardwareSerial

Yet ultimately does check:
m_hardwareIdHigh

comparing it against a serial

REPOSITORY
  R127 KWayland

BRANCH
  arcpatch-D26858

REVISION DETAIL
  https://phabricator.kde.org/D26858

To: apol, #kwin, #frameworks, zzag
Cc: davidedmundson, zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200317/e42a889d/attachment.html>


More information about the Kde-frameworks-devel mailing list