D27544: Fix update scenarios with no explicit downloadlink selected
Dan Leinir Turthra Jensen
noreply at phabricator.kde.org
Tue Mar 17 12:40:00 GMT 2020
leinir updated this revision to Diff 77818.
leinir marked 4 inline comments as done.
leinir added a comment.
Address @ahiemstra's comments - thanks!
- Turn on C++14 support
- Fix some whitespace issues, a leak, and add a warning
- Less magic numbers, with the power of enums
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27544?vs=77494&id=77818
BRANCH
fix-update (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D27544
AFFECTED FILES
CMakeLists.txt
src/core/engine.cpp
src/core/jobs/httpworker.cpp
src/core/security.cpp
src/qtquick/qml/EntryDetails.qml
src/qtquick/qml/NewStuffItem.qml
src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml
src/qtquick/qml/private/entrygriddelegates/ThumbDelegate.qml
src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml
src/qtquick/quickitemsmodel.cpp
src/qtquick/quickitemsmodel.h
To: leinir, #knewstuff, #frameworks, #plasma, ngraham, apol, #discover_software_store
Cc: ahiemstra, alexde, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200317/1ab0ee88/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list