D28078: guard against duplicated service discoveries

Harald Sitter noreply at phabricator.kde.org
Mon Mar 16 14:43:19 GMT 2020


sitter created this revision.
sitter added a reviewer: ngraham.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  if both dnssd and wsdiscovery have the same server on offer we'd create
  duplicated entries. instead keep track of the discovered names and only
  use the first discovery. notably happens when using wsdd on linux where
  samba would also register itself on dnssd.
  
  for ease of access and to not have to roundtrip through udsentry, discovery
  objects now have a udsName function that is meant to be the exact name
  used for the udsentry.

TEST PLAN
  - have samba
  - run wsdd.py from https://github.com/christgau/wsdd
  - server only shows up once

REPOSITORY
  R320 KIO Extras

BRANCH
  smb-no-dupes

REVISION DETAIL
  https://phabricator.kde.org/D28078

AFFECTED FILES
  smb/discovery.h
  smb/dnssddiscoverer.cpp
  smb/dnssddiscoverer.h
  smb/kio_smb_browse.cpp
  smb/wsdiscoverer.cpp
  smb/wsdiscoverer.h

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200316/aa477ffe/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list