D27947: Port away from deprecated QList::toSet()

Ahmad Samir noreply at phabricator.kde.org
Fri Mar 13 13:10:10 GMT 2020


ahmadsamir added inline comments.

INLINE COMMENTS

> apol wrote in kcoredirlister.cpp:1045
> Is this to force dir at the end?

You mean at the front? I am not sure, but I matched the behaviour of the original code, it first appended "dir" then the QUrl list from canonicalUrls. It sort of makes sense, since we want to update the listing (kcoredirlister) of "dir" then the symlinks to it. From the comment right before canonicalUrls declaration[1], see https://bugs.kde.org/show_bug.cgi?id=213799

[1] https://cgit.kde.org/kio.git/tree/src/core/kcoredirlister_p.h#n474

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27947

To: ahmadsamir, #frameworks, dfaure, meven
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200313/1a761143/attachment.html>


More information about the Kde-frameworks-devel mailing list