D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

[David Faure]

dfaure added a comment.


  Thanks for the unittest with the fix.

INLINE COMMENTS

> krununittest.cpp:238
> +{
> +    const QString ktelnet = QStringLiteral(CMAKE_SOURCE_DIR) + QStringLiteral("/src/ioslaves/telnet/ktelnetservice5.desktop");
> +    const KService service(ktelnet);

QFINDTESTDATA() is more flexible than a solution like CMAKE_SOURCE_DIR [e.g. it allows deploying unittests to android devices]. It's also simpler to use (no buildsystem change).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27999

To: ahmadsamir, #frameworks, dfaure, sitter, meven, feverfew
Cc: feverfew, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200312/95606e2f/attachment.html>