D25302: Remove stale symlink

David Faure noreply at phabricator.kde.org
Tue Mar 10 01:38:03 GMT 2020


dfaure added inline comments.

INLINE COMMENTS

> karchive.cpp:986
> +                // link target or be non-relative
> +                if (QFile::exists(linkName) && linkName != curEntry->symLinkTarget()) {
> +                    QFile::remove(linkName);

This is comparing the name of the symlink with the new target. Was this supposed to be looking at the target of the old symlink instead?

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D25302

To: sandsmark, dfaure
Cc: dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200310/fbdaa541/attachment.html>


More information about the Kde-frameworks-devel mailing list