D25315: KDirModel: implement showing a root node for the requested URL

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> kdirmodel.cpp:222
> +        QUrl parent(url.adjusted(QUrl::RemoveFilename|QUrl::StripTrailingSlash));
> +        if (url.path() == QLatin1String("/"))
> +            parent.setPath(QString());

Braces around if.

> kdirmodel.h:79
> +     * @param url   the URL of the directory whose contents should be listed.
> +     *              Unless ShowRoot is set, the item for this directory will NOT be shown, the model starts at its children.
> +     * @param flags see OpenUrlFlag

I suggest:
s/its children/the first child/ OR
s/at its children/directly at the first child/

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25315

To: dfaure, stefanocrocco, elvisangelaccio, meven, apol
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200307/8fe80e5d/attachment-0001.html>