D26342: Allow overriding to disable auto language detection

Albert Astals Cid noreply at phabricator.kde.org
Sat Mar 7 09:33:38 GMT 2020


aacid added inline comments.

INLINE COMMENTS

> backgroundchecker.cpp:147
>  {
> +    d->autoDetectLanguageDisabled = true;
>      d->currentDict = speller;

question from someone that has never really used this setSpeller API.

Is this behaviour change for sure 100% of the times wanted?

If not you should add a new API that is setSpeller(speller, bool)

> backgroundchecker.cpp:179
>      // this sets language only for current sentence
> +    d->autoDetectLanguageDisabled = true;
>      d->currentDict.setLanguage(lang);

same question here

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D26342

To: sdepiets, #frameworks, cullmann, mlaurent, mludwig
Cc: aacid, mludwig, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200307/ecfb6e60/attachment.html>


More information about the Kde-frameworks-devel mailing list