D27463: KconfigXT: Add a value attribute to Enum field choices

Méven Car noreply at phabricator.kde.org
Thu Mar 5 10:32:12 GMT 2020


meven marked 4 inline comments as done.
meven added inline comments.

INLINE COMMENTS

> ervin wrote in kcoreconfigskeleton.cpp:580
> No I meant the comment needs to be adjusted due to the changes (fields changing place and such) sorry if I was unclear.

I updated the comment since your first comment, I think it is ok now.

> ervin wrote in kcoreconfigskeleton.h:788
> Yeah, noticed only later... I wonder if it's more obvious in the header or the cpp...

I expect those to be found through grep, and I had comments in the past to put it somewhere where it could not get in documentation, in cpp guarantees this.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27463

To: meven, ervin, bport, crossi, #frameworks
Cc: ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200305/3a7a7fb4/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list