D27801: smb: add a unit test for smburl

Harald Sitter noreply at phabricator.kde.org
Tue Mar 3 10:31:38 GMT 2020


sitter created this revision.
sitter added a reviewer: ngraham.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  only tests some of the obvious scenarios I can see right now.
  
  ::cd() has been changed to only support going up one path element. it's
  all we need it for and the previous code was almost certainly incorrect
  by calling setUrl with input that is definitely not anywhere near a valid
  url

TEST PLAN
  builds and test passes

REPOSITORY
  R320 KIO Extras

BRANCH
  smb-smburl-static-autotest

REVISION DETAIL
  https://phabricator.kde.org/D27801

AFFECTED FILES
  smb/CMakeLists.txt
  smb/autotests/CMakeLists.txt
  smb/autotests/smburltest.cpp
  smb/smburl.cpp

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200303/0ddc45df/attachment.html>


More information about the Kde-frameworks-devel mailing list