D26868: Move newItem to private method in KConfigSourceGenerator

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Tue Jan 28 18:05:21 GMT 2020


kossebau added a comment.


  And more while at it: for latin1 strings used in concatenation it is recommended to use QLatin1String and for single chars QLatin1Char. QStringLiteral is more expensive here, and QStringBuilder & QString has proper overloads for the concatenations. So you want to keep the QLatin1Strings and rather turn those for single chars to QLatin1Char.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26868

To: tcanabrava, ervin, dfaure
Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200128/113285c4/attachment.html>


More information about the Kde-frameworks-devel mailing list