D25583: Quit baloo_file_extractor if DB transaction fails

Stefan BrĂ¼ns noreply at phabricator.kde.org
Fri Jan 24 09:33:09 GMT 2020


bruns added a comment.


  I will try to cook up a more complete solution over the weekend.

INLINE COMMENTS

> app.cpp:119
>      } else {
> -        m_tr->commit();
> +        bool rc = m_tr->commit();
>          delete m_tr;

This is a little bit confusing, as the lmdb code uses `rc == LMDB_OK == 0`, but here `0 == ERROR`.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D25583

To: davidedmundson, bruns, ngraham
Cc: meven, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200124/096dd9e6/attachment.html>


More information about the Kde-frameworks-devel mailing list