D26858: Provide an implementation for the tablet interface

[Vlad Zahorodnii]

zzag requested changes to this revision.
zzag added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> test_tablet_interface.cpp:2
> +/********************************************************************
> +Copyright 2014  Martin Gräßlin <mgraesslin at kde.org>
> +

Haven't you written this autotest?

> test_tablet_interface.cpp:40
> +
> +class Tablet : public QtWayland::zwp_tablet_v2 {
> +public:

The opening has to be on its own line.

> test_tablet_interface.cpp:78-79
> +
> +    QVector<Tablet*> m_tablets;
> +    QVector<Tool*> m_tools;
> +

Put a single space before `*` and `&`.

> test_tablet_interface.cpp:205
> +{
> +    TabletSeatInterface* s = m_tabletManager->seat(m_seat);
> +    QVERIFY(s);

No short names.

> test_tablet_interface.cpp:225
> +    QCOMPARE(m_surfaces.count(), 3);
> +    for (auto s : m_surfaces) {
> +        m_tool->setCurrentSurface(s);

No `auto`.

https://community.kde.org/Policies/Library_Code_Policy#auto_Keyword

> test_tablet_interface.cpp:231
> +
> +static uint n = 0;
> +void TestTabletInterface::testInteractSimple()

What's `n`?

> tablet_interface.h:46
> +
>  class KWAYLANDSERVER_EXPORT TabletManagerInterface : public QObject
>  {

This revision seems to be incomplete. I don't see where `TabletManagerInterface` was introduced.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D26858

To: apol, #kwin, #frameworks, zzag
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200123/49becf2f/attachment.html>