D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

[Kevin Ottens]

ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.


  Just a tiny nitpick left.

INLINE COMMENTS

> managedconfigmodule.cpp:175
> +                                   , d->_skeletons.end()
> +                                   , [](const QPointer<KCoreConfigSkeleton> &value){ return value.isNull(); });
> +    d->_skeletons.erase(toRemove, d->_skeletons.end());

Nitpicking but in function call we generally don't have commas at the start of line but at the end of the line before. Also there should be a space after the closing parenthesis of the lambda declaration.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D26046

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200122/6f067ef1/attachment.html>