D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

Ahmad Samir noreply at phabricator.kde.org
Fri Jan 17 07:32:16 GMT 2020


ahmadsamir added inline comments.

INLINE COMMENTS

> dfaure wrote in kcoredirlister.cpp:2306
> I think you said this would anchor twice, in another review? Needs to be fixed then.
> 
> (Good for readability!)

Right. (I searched through all the porting commits, I missed this one as it hasn't committed yet...).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26659

To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200117/70ce8364/attachment.html>


More information about the Kde-frameworks-devel mailing list