D26670: ki18n_wrap_ui: error when file doesn't exist

Christoph Cullmann noreply at phabricator.kde.org
Thu Jan 16 19:18:46 GMT 2020


cullmann added inline comments.

INLINE COMMENTS

> kossebau wrote in KF5I18nMacros.cmake.in:52
> This assumes a relative path given. It might make sense to also deal with absolute path, and only append CMAKE_CURRENT_LIST_DIR if not absolute, then check for existance?

Some lines below we anyways do

get_filename_component(_tmp_FILE ${_current_FILE} ABSOLUTE)

Could we not just use the result of this for both the check + output?

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D26670

To: davidre, #framework_syntax_highlighting, #localization, #build_system
Cc: cullmann, ngraham, kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200116/ad59c3f1/attachment.html>


More information about the Kde-frameworks-devel mailing list