D26692: Fix QRegularExpression::wildcardToRegularExpression() usage

Ahmad Samir noreply at phabricator.kde.org
Wed Jan 15 19:03:13 GMT 2020


ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  It turns out that QRegularExpression::wildcardToRegularExpression() returns
  an anchored (with \A and \z) pattern, so using anchoredPattern() in such
  cases would actually anchor the pattern twice, which is obviously wrong.
  Thanks to Mikołaj Płomieński (blaze) for catching it in
  https://phabricator.kde.org/D26205#594891

TEST PLAN
  make && ctest

REPOSITORY
  R241 KIO

BRANCH
  l-qregularexpression-too-wildcard (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26692

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp
  src/kpac/script.cpp

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200115/9df2e1c6/attachment.html>


More information about the Kde-frameworks-devel mailing list