D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

Kai Uwe Broulik noreply at phabricator.kde.org
Tue Jan 14 12:44:19 GMT 2020


broulik added inline comments.

INLINE COMMENTS

> kcoredirlister.h:595
>       */
> -    virtual bool doNameFilter(const QString &name, const QList<QRegExp> &filters) const;
> +    virtual bool doNameFilter(const QString &name, const QVector<QRegularExpression> &filters) const;
>  

This class is exported, you cannot change this existing method and you also cannot add a new `virtual`, see https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26659

To: ahmadsamir, dfaure
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200114/6453776c/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list