D26634: Correctly compute bottom margin for grid delegates with subtitles

[George Vogiatzis]

gvgeo added inline comments.

INLINE COMMENTS

> GridDelegate.qml:81
>          height: Kirigami.Settings.isMobile ? Math.round((delegate.width - Kirigami.Units.gridUnit) / 1.6)
>                                             : Math.min(delegate.GridView.view.implicitCellHeight - Kirigami.Units.gridUnit * 3,
>                                                        delegate.height - Kirigami.Units.gridUnit)

Maybe need to add caption.visible check, instead of always removing 3 gridUnits?
Was changed from 2 in the previous commit.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D26634

To: ngraham, #vdg, #plasma, broulik
Cc: gvgeo, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200113/21c2410b/attachment-0001.html>