D26487: [Kuit] Revert changes in parseUiMarker()

Ahmad Samir noreply at phabricator.kde.org
Tue Jan 7 09:32:15 GMT 2020


ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, ilic, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  This commit partially reverts a9f4cbdda790c3962 <https://phabricator.kde.org/R249:a9f4cbdda790c3962635605cee69be882f209e25>:
  
  - A simple regex is used to find the first whitespace
  - Use QString::indexOf() to search for ':' and '/'
  
  This is faster than using a complex regex. For more details see the
  discussion in D26366 <https://phabricator.kde.org/D26366>.

TEST PLAN
  make && ctest

REPOSITORY
  R249 KI18n

BRANCH
  l-parseMarkup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26487

AFFECTED FILES
  src/kuitmarkup.cpp

To: ahmadsamir, #frameworks, ilic, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200107/a96a2d0d/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list