D26407: KFileItem: improve isSlow to never block, make SkipMimeTypeFromContent skip only network fs

Anthony Fieroni noreply at phabricator.kde.org
Sat Jan 4 11:03:43 GMT 2020


anthonyfieroni added inline comments.

INLINE COMMENTS

> kfileitem.cpp:49-50
> + */
> +static KMountPoint::List mountPoints;
> +static QDateTime lastMountPointUpdate;
> +

Put them in `getMountPoints` as local static variables, global static are no-go.

> dfaure wrote in kfileitem.cpp:787
> This is not really true. We have that problem in the FreeBSD CI, where there's no /etc/fstab, the mounting is handled by some container stuff I don't really understand...
> 
> You have more reliable ways to know you're on android...

Empty mountPoints means no fstab.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26407

To: meven, #frameworks, ngraham, broulik, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200104/4a2b5df1/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list