D24466: Use ECMGenerateExportHeader to manage deprecated API better

Kai Uwe Broulik noreply at phabricator.kde.org
Fri Jan 3 21:18:28 GMT 2020


broulik added inline comments.

INLINE COMMENTS

> ktoolbar.cpp:908
>  {
> -#ifndef KXMLGUI_NO_DEPRECATED
> +#if KXMLGUI_BUILD_DEPRECATED_SINCE(5, 0)
>      if (mainWindow() && d->enableContext) {

I just realized this is false-y deprecated. The feature adds the configuration options for toolbar buttons.
What needs to be done here for proper deprecation is port that over to `customContextMenuRequested` or checking for policy being not `NoContextMenu` or so.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D24466

To: kossebau, #frameworks, dfaure, mlaurent
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200103/8431c790/attachment.html>


More information about the Kde-frameworks-devel mailing list