D26360: [Kuit] Port QRegExp to QRegularExpression, second pass

Ahmad Samir noreply at phabricator.kde.org
Thu Jan 2 12:32:16 GMT 2020


ahmadsamir added inline comments.

INLINE COMMENTS

> apol wrote in kuitmarkup.cpp:412
> Why did you change [i] to at(i)?

According to the QList docs, at() should be used for read-only access, it could be faster than [] and it never causes a detach.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D26360

To: ahmadsamir, #frameworks, ilic, dfaure, mlaurent, aacid
Cc: apol, ltoscano, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200102/243f06d9/attachment.html>


More information about the Kde-frameworks-devel mailing list