D26211: Port QRegExp to QRegularExpression

Ahmad Samir noreply at phabricator.kde.org
Sat Feb 29 21:03:47 GMT 2020


ahmadsamir updated this revision to Diff 76705.
ahmadsamir added a comment.


  - Move the QRegularExpression definition out of the for loop, more efficient as it'll reused
  - match() always allocates a QRegularExpressionMatch anyway, so move it inside the while loop
  - Make the first () non-capturing since the capture group isn't needed

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26211?vs=72149&id=76705

BRANCH
  l-qregularexpression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26211

AFFECTED FILES
  data/parsetrigrams.cpp

To: ahmadsamir, cullmann, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200229/d6b3afae/attachment.html>


More information about the Kde-frameworks-devel mailing list