D25315: KDirModel: implement showing "/" as a root node, optionally

[David Faure]

dfaure added a comment.


  In D25315#619727 <https://phabricator.kde.org/D25315#619727>, @rrosch wrote:
  
  > > Keep only matters for further calls to openUrl, not the first one. It's about whether to *add* or *replace* the currently open URL.
  > >  KDirModel takes care of that.
  >
  > Ah ok, so it's going to do that without me needing to explicitly specify "Keep"?
  
  
  Yes. Basically KDirModel is one layer above KDirLister, it encapsulates it. If you use KDirModel, you shouldn't have to use KDirLister API directly.
  
  >>> Which should show the node for "/home" as the root, but is instead giving me a flat listing of all the child nodes without "/home" as the root.
  >> 
  >> Oh, hmm, that's not how setRootIndex works (that's a *view* feature, we can't change that).
  >>  I changed the model to have one more node for "/", while I see now that what you want is that it *always* shows a root node even when the root is another directory.
  > 
  > Yeah that was my intent with the above. How come it doesn't work in the view for `file:///home/myuser` but it works for `file:///`?
  
  I thought the plan was to always show a tree that starts at the root, like iirc the old "Root" tab in konqueror-kde4, or the Root tree view in dolphin.
  This is why KDirModel::openUrl("file:///home/myuser", ShowRoot) shows
  
    "/"
    | - home
        | - myuser
  
  > In any case, the code here you provided works great for at least `file:///` and that gets us quite far. How much of a rework would getting it to work with subdirectories (like `file:///home/myuser`) take?
  
  No idea. I'll work on it and let you know how much work it was :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25315

To: dfaure, stefanocrocco, elvisangelaccio, meven, apol
Cc: rrosch, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200229/bb464e59/attachment.html>