D27097: Port from QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir added a comment.


  Looking at the incremental stuff some more, there are no public methods that mention incremental; the only way is to set the KFind::FindIncremental flag; the only method I could find is in the private API (find_p.h) startNewIncrementalSearch(). So technically it's all hidden behind the d-pointer, there's nothing to deprecate about incremental search, except remove the flag/enum FindIncremental... (does that mean we can remove the incremental code now, or wait till the KF6 branching?).
  
  FWIW, I checked lxr again and KFind::FindIncremental exists only in kmplayer and khtml, and in both cases it's in commented out code.

REPOSITORY
  R310 KTextWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27097

To: ahmadsamir, #frameworks, mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200225/398d809c/attachment.html>